- 19 Mar, 2022 2 commits
-
-
Jenkins authored
Change-Id: I5495d75a0c021aa757437d505215fc8a68dd941d Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287504 Tested-by:
Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
-
Jenkins authored
Change-Id: I2e28b7349617a2cd93acdce1265a4e509fd2035f Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287503 Tested-by:
-
- 18 Mar, 2022 23 commits
-
-
jake.oeding authored
fixes MAT-743 flag=react_discussions_post flag=rce_mentions_in_discussions test plan: -enable the feature flags -have a course with multiplea people enrolled -navigate to discussions -start a discussion or comment in an existing one -trigger the mention dropdown by typing @ in the RCE -run the a11y checker >observe it does not complain about alt text on the avatar images Change-Id: Ieb5293d18d1721ef8d714f8ac46d6c835f8990f7 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287430 Reviewed-by:
Weston Dransfield <wdransfield@instructure.com> QA-Review: Weston Dransfield <wdransfield@instructure.com> Product-Review: David Lyons <lyons@instructure.com> Tested-by:
-
Jeremy Stanley authored
test plan: - do API calls to /api/v1/accounts/X/users?enrollment_type[]=Y where Y includes: - plain enrollment types like `student`, `teacher`, or `ta` (this is what is documented and what works today) - full enrollment types like `StudentEnrollment` or `TaEnrollment` (this doesn't work but Sentry logs show a lot of people try it anyway, so we'll make it work) - snake case enrollment types like `student_enrollment` - might as well make those work too - invalid enrollment types like `lolcats`. this should result in a 400 error with a meaningful error result, and not, as happens today, with a 500 error and an error_report flag=none fixes DE-1094 fixes CANVAS-HQJX Change-Id: I38b6a788d41ee68aad426e159d15df16ec1a0e4a Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287471 QA-Review: Isaac Moore <isaac.moore@instructure.com> Product-Review: Jeremy Stanley <jeremy@instructure.com> Tested-by:Isaac Moore <isaac.moore@instructure.com>
-
Aaron Shafovaloff authored
test plan: - tests pass flag=none Refs EVAL-2337 Change-Id: I0588b50449b713744acb92ac2173c34fb85f58af Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287373 QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Tested-by:
Spencer Olson <solson@instructure.com> Product-Review: Syed Hussain <shussain@instructure.com>
-
Jeremy Stanley authored
because with just a bit of effort, this is a generically useful component test plan: - direct share "Copy To" feature still works (this is the component that chooses a course and module to copy into; I want to appropriate it for something else) - if you are an admin, you need to start typing a course name before any appear in the dropdown box - if you are a teacher who is not an admin, the box will be prepopulated with your courses flag=none refs DE-1046 Change-Id: Ia5ed75bc987c04b9510dad58c0688feca6e2c76e Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287456 Tested-by:Ed Schiebel <eschiebel@instructure.com> QA-Review: Ed Schiebel <eschiebel@instructure.com> Product-Review: Jeremy Stanley <jeremy@instructure.com>
-
Jeremy Stanley authored
Change-Id: I6e104a6b47413dfbbe493362241821d9ba69c024 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287461 Reviewed-by:
Andrea Cirulli <andrea.cirulli@instructure.com> Tested-by:
-
Evan Battaglia authored
Lti::ResourceLinks are a LTI 1.3 concept, but there are a few code paths where resource_link.current_external_tool can end up pointing to a 1.1 tool. This can cause problems, for instance when the LTI 1.1 tool has no URL and the resource link is exported (see the diagrams in the ticket). Please see last step in test plan for a behavior question I have. Test plan: - Create two resource links with an LTI 1.3 tool: * an LTI assignment * another resource link such as those created for a module item or an embedded RCE LTI link - Export the course - Uninstall the LTI 1.3 tool and make an LTI 1.1 tool with no URL but with the domain the same as the LTI 1.3 tool's URLs. - From the console, get each resource link and run the folllowing: For the assignment resource link: lti_resource_link.current_external_tool(lti_resource_link.assignment.course) For the other resource link: lti_resource_link.current_external_tool(lti_resource_link.course) They should both be nil - Export the course again and check the imscc file. There should be no resource links - Import the first course export file into another course and make sure no LTI resource links have been created. - Note: the assignment will be created with the URL of the 1.3 tool. As a result, the ContentTag will point to the 1.1 tool, so it will look like an LTI 1.1 Assignment. I think it would be weird if we created the Lti::ResourceLink or ContentTag pointing to a deleted 1.3 tool (and if we imported into another account where the the 1.3 tool never existed, we'd run into the same scenario anyway). The only other option is not create the assignment at all, but that seems worse than creating a broken assignment closes INTEROP-7258 flag=none Change-Id: Ic8f4a3107f311a15a603c023503d692737621846 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/285580 Reviewed-by:Mysti Lilla <mysti@instructure.com> QA-Review: Xander Moffatt <xmoffatt@instructure.com> Product-Review: Evan Battaglia <ebattaglia@instructure.com> Tested-by:
-
Aaron Shafovaloff authored
test plan: - tests pass Refs EVAL-2337 flag=none Change-Id: Ica78219d62281e6226cccc5301d3b11f696a4ca3 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287441 Tested-by:
Eduardo Escobar <eduardo.escobar@instructure.com>
-
Brian Watson authored
flag=none Test-plan: - manually run ruby coverage / js coverage / axe builds - ensure artifacts are updated in s3 Change-Id: I2bd4e51eedecf5a10e5d96bdc8727abb17bac034 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286063 Tested-by:
Kyle Rosenbaum <krosenbaum@instructure.com> Reviewed-by:
James Butters <jbutters@instructure.com> QA-Review: Brian Watson <bwatson@instructure.com> Product-Review: Brian Watson <bwatson@instructure.com>
-
Ahmad Amireh authored
refs FOO-2697 flag = none remove the @instructure/ui-babel-preset dependency and instead define babel config for the 3 needed targets: 1. ESM, output by "npm run build:es" and used while working on the planner or on canvas (webpack) 2. optimized ESM, this is what is used in deploys, output by "NODE_ENV=production npm run build:es" 3. CJS, used in the canvas jest build ~test plan ~ see deltas/esm-prod.patch in the initial patchset for the relevant changes to the production target Change-Id: I606de095126dd80eaafe7399dac8635f4bcce732 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283950 Tested-by:
-
Jacob Burroughs authored
Change-Id: I638b51ee690780e48ef99ebf9213a0134fb46cc6 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287436 Reviewed-by:
August Thornton <august@instructure.com> Tested-by:
-
Jacob Burroughs authored
Also teach brand configs to work cross-shard. For siteadmin we don't use a theme so we won't actually hit that, but if we added one it would be cached once per app server. For consortia it also is well-cached fixes FOO-2625 Change-Id: I010a139c2d3426bca06433cbacc3b0ca0f22d1af Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286815 Tested-by:
Ahmad Amireh <ahmad@instructure.com> QA-Review: Jacob Burroughs <jburroughs@instructure.com> Product-Review: Jacob Burroughs <jburroughs@instructure.com>
-
Omar Gerardo Soto-Fortuño authored
flag=none closes VICE-2582 Test Plan: - Tests pass Change-Id: I4251a025e46caf0b0a929c960ad963ddefd9e228 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287234 Reviewed-by:
Chawn Neal <chawn.neal@instructure.com> Product-Review: Chawn Neal <chawn.neal@instructure.com> Tested-by:
-
August Thornton authored
This reverts commit bd24990d. Reason for revert: not desirable for customers Change-Id: Id158a7b41a9b69042a31c99d88498466807d1fae Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286894 Tested-by:
-
Jacob Burroughs authored
Change-Id: Ief68aa38fd3eec02ed01a77e50f155539ca1e297 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287384 Tested-by:
Aaron Ogata <aogata@instructure.com> QA-Review: Jacob Burroughs <jburroughs@instructure.com> Product-Review: Jacob Burroughs <jburroughs@instructure.com>
-
Jenkins authored
Change-Id: I053cefea51d23d99fe35cf34a556ec607d15480c Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287395 Tested-by:
-
Jenkins authored
Change-Id: I2966bbf4a8386de24b237f92524f304aad5b22e4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287394 Tested-by:
-
Jenkins authored
Change-Id: Ic2444b216a5519ae0bde3bd876f1408f085897a3 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287393 Tested-by:
-
Jenkins authored
Change-Id: Iaefd8ea26449942f4e27359f8c23551194ebe933 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287392 Tested-by:
-
Jenkins authored
Change-Id: Ia3cb1119154301f0c2ab88de9bc64554a1d368e9 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287391 Tested-by:
-
Jenkins authored
Change-Id: I1aad607412da805443746ebcd1670367144a993a Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287390 Tested-by:
-
Jenkins authored
Change-Id: Icb8a332168a0c36c856d7f6b24ed64bb03dad610 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287389 Tested-by:
-
Jenkins authored
Change-Id: Iff0ecb11cb8e5dd9d18ca729a1a25172405f65d1 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287388 Tested-by:
-
Jenkins authored
Change-Id: I272e939ff235c373d3b775d97fa4c8c608ba6cc0 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287387 Tested-by:
-
- 17 Mar, 2022 15 commits
-
-
Weston Dransfield authored
closes MAT-780 flag=none Test Plan: - Validate the enhanced student submission view allows recording and uploading media - Validate clicking tabs on the canvas-media upload modal switches them as expected Change-Id: I95a49a2df8e5a74d2012c915d1f132e94d1970d2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287374 Tested-by:
Dustin Cowles <dustin.cowles@instructure.com> QA-Review: Dustin Cowles <dustin.cowles@instructure.com> Product-Review: Weston Dransfield <wdransfield@instructure.com>
-
Aaron Shafovaloff authored
test plan: - all tests pass flag=none Change-Id: I50e858039081b8bd0c5a497cdf9e697710a54dc5 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287364 Tested-by:
-
Luis Oliveira authored
Makes the link resolver forcefully ignore a faulty migration_id as to not pull up the wrong resource on replacement. Also, creates attachments on the fly for orphan media objects being exported so a valid migration_id is generated. fixes LS-3033 flag=none Test plan: 1. Create 2 wiki pages 2. To one of them, add 2 embedded videos via RCE 3. To a second one, add just 1 video 4. Make sure the 3 videos are different 5. Delete or alter the ids of the created media objects' attachments 6. (without this fix) Via share content, share the pages separatelly with yourself 7. Check that the export manifest has the same identifiers for the orphan media objects 8. Apply this fix and share the pages again 9. Check that the manifest for the new export has different identifiers, and the media objects are no longe orphans 10. Import the 2 first shares to a course 11. Import the 2 last shares to a different course 12. Check that the pages display the correct videos in both course Change-Id: Ia283fc7e4c8c36f2ac9507944b9fcfa7f4cfcf64 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287171 Tested-by:Robin Kuss <rkuss@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
-
Aaron Shafovaloff authored
Also - Removed two unused imports - eslint did some pre-commit autoformatting test plan: - All tests pass Refs EVAL-2337 flag=none Change-Id: I895288dfda54ad5dbb730df1dafb52f2e5198f31 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287359 Reviewed-by:
-
Chrystal Langston authored
closes OUT-5029 flag=improved_outcomes_management test plan: - Enable IOM FF - Navigative to Course -> Outcomes - Create a new group - Select the newly created group in the Tree - Click on the kebab menu on the right hand side and click Edit - Add a VERY long description for the group and save - Click on the kebab menu again and this time click View Description - Using the tab key, assert that you can tab to the description and it is highlighted. - Assert that you can use the up and down arrows to scroll to view the description - Repeat the steps in Account Change-Id: I61044b3c2c171e4476f60bd399f9b5eacc1b7705 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287291 Tested-by:
Martin Yosifov <martin.yosifov@instructure.com> QA-Review: Martin Yosifov <martin.yosifov@instructure.com> Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
-
Ed Schiebel authored
closes LS-3043 flag=none test plan: - the canvas build completes without a warning about "Module not found: Error: Can't resolve './rce/translations/locales ..." Change-Id: Id0cc37b44aeaa24b62d494051204c2d398b7d476 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287337 Tested-by: -
Aaron Shafovaloff authored
test plan: - All tests pass Refs EVAL-2337 flag=none Change-Id: I01cf3ed67476a3e38ea86686768016b456874128 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287356 Reviewed-by:
Syed Hussain <shussain@instructure.com> Tested-by:
-
Aaron Shafovaloff authored
test plan: - All tests pass flag=none Refs EVAL-2337 Change-Id: Ia76799b06b341e5ad9f66ff578699c5fbc49cb28 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287346 Tested-by:
-
Xander Moffatt authored
closes INTEROP-7350 flag=none why: * to integrate this PR: https://github.com/instructure/canvas-lms/pull/2031 test plan: * with a tool with a deployment_id (1.3) * get the list of tools for that context, the JSON for that tool should have deployment_id * get the specific tool API, the JSON returned should have deployment_id Change-Id: Ie926e304ab7dba7e50c80fd6ce6ef8bec46dda78 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287340 Tested-by:
Tucker Mcknight <tmcknight@instructure.com> QA-Review: Tucker Mcknight <tmcknight@instructure.com> Product-Review: Xander Moffatt <xmoffatt@instructure.com>
-
Caleb Guanzon authored
fixes VICE-2544 flag=react_inbox test plan: - as an admin, message a user without selecting a course - go to your sent mailbox - reply to that message you sent - verify that you can reply just fine Change-Id: Id0d2ed44466579c38086d813e569701492030049 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287332 Tested-by:
Jeffrey Johnson <jeffrey.johnson@instructure.com> Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com> QA-Review: Drake Harper <drake.harper@instructure.com>
-
Aaron Shafovaloff authored
flag=none Refs EVAL-2337 Change-Id: Id6515e4615ccdff496e308161b8204f8379a92fd Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287343 Tested-by:
-
Aaron Shafovaloff authored
flag=none Change-Id: I97788bc0bed481c42c13c2b6ab3b2335cf4c4a48 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287345 Tested-by:
-
Jonathan Guardado authored
Synced items are now placed starting from the last manually created item position. fixes: LS-3020 flag= none Test plan: - Create two courses set one as a blueprint and the other one as associated - Create a module in the blueprint course with two items on it then sync that to the associated course - In the associated course, create manually two items and move one bellow of the blueprint items and place the other one in the middle of both blueprint items - In the blueprint, make any change on the module and sync that change - In the associated course, notice that the manually created items are above of all blueprint items and keep their order, as it is described on canvas guide Change-Id: I9519846bb82ba0efdf1359d46c4ed0fa309e8b97 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287075 Tested-by:
-
Aaron Ogata authored
Change-Id: I255e5cd7f40e7eed661c68005468bd06d84d3f7a Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287341 Reviewed-by:
-
James Butters authored
Change-Id: Id0efe7b2d8e19764e199278a490c9175e541b5d0 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287342 Reviewed-by:
-
