- 23 Mar, 2022 4 commits
-
-
Jenkins authored
Change-Id: If520183cffb3519e00beec0aa8357af9cbac45b1 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287737 Tested-by:
Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
-
Jenkins authored
Change-Id: Ia712a4447778cef8d06b0452fc0e443d9f2e331a Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287736 Tested-by:
-
Dustin Cowles authored
important_dates, muted, anonymize_students, require_lockdown_browser fixes EVAL-2211 flag=none Test plan: - Generate docs - Confirm fields are included in doc/api/assignments.html Change-Id: I0fd2f7d31fdfea84493e13acad4f02cf4bb748fa Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287611 Tested-by:
Eduardo Escobar <eduardo.escobar@instructure.com> Reviewed-by:
Kai Bjorkman <kbjorkman@instructure.com> QA-Review: Dustin Cowles <dustin.cowles@instructure.com> Product-Review: Jody Sailor
-
Jackson Howe authored
closes LS-3047 flag = observer_picker Change-Id: I689f5fb16729183966afae3cd4ac092c9851ef02 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287722 Tested-by:
Eric Saupe <eric.saupe@instructure.com> QA-Review: Eric Saupe <eric.saupe@instructure.com> Product-Review: Jackson Howe <jackson.howe@instructure.com>
-
- 22 Mar, 2022 17 commits
-
-
Jacob Burroughs authored
current_pool was an old switchman special that isn't needed on rails 6.1+ fixes CANVAS-HWDH Change-Id: I98c60154b5a572669adeaada5e8cfe8dc1347033 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287731 Reviewed-by:
Aaron Ogata <aogata@instructure.com> Tested-by:
-
Jacob Burroughs authored
Change-Id: Ia83164d6f145af4d60303e139a13bd2e68d6e7eb Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287703 Tested-by:
-
Alexandre Trindade authored
why The assignment_selection placement accepts LtiResourceLink content item type which can indicate the preferred dimension of the iframe LtiResourceLink should use iframe width and height attributes when received Specification: http://www.imsglobal.org/spec/lti-dl/v2p0#content-item-types refs INTEROP-7320 flag=none -------------------------------------------------- Test plan -------------------------------------------------- - In a course, go to Assignments page - Click in "+ Assignment" button - In "Submission Type" combo box, choose External Tool - click in the "Find" button to find an External Tool - Choose the LTI 1.3 Test tool - in the textarea "iframe (JSON)" use the JSON `{"width":222,"height":888}` - send the deep linking request - The height will be in a hidden HTML element #assignment_external_tool_tag_attributes_iframe_height - The width will be in a hidden HTML element #assignment_external_tool_tag_attributes_iframe_width - The assignment should launch with the received dimensions Change-Id: I4267dd59effc6a3ec586973b854649ea17c2c57d Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/284192 Reviewed-by:
Xander Moffatt <xmoffatt@instructure.com> QA-Review: Xander Moffatt <xmoffatt@instructure.com> Tested-by:
-
Jonathan Guardado authored
It looks like timeout is not the issue root cause for the 'shows the observee missing items on dashboard cards' unit test, the API call fails in some Jenkins builds, let’s skip it for now until we reproduce the issue locally refs: LS-3048 flag= none Test plan: - Passes Jenkins Change-Id: I5693f7e600d6e9b71f7673fdf8458ecd320bc98e Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287721 Reviewed-by:
Robin Kuss <rkuss@instructure.com> QA-Review: Robin Kuss <rkuss@instructure.com> Tested-by:
-
Jacob Burroughs authored
Change-Id: I2c82c7514d067dde79ebb2b8a737b6f26ef3498f Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287715 Reviewed-by:
-
Omar Gerardo Soto-Fortuño authored
flag=none closes VICE-2585 Test Plan: - Tests pass Change-Id: Id4d5d0f25eb887b8e8d4fa52a4afd16363bdba8e Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287681 Tested-by:
Caleb Guanzon <cguanzon@instructure.com> Product-Review: Caleb Guanzon <cguanzon@instructure.com> QA-Review: Chawn Neal <chawn.neal@instructure.com>
-
Jackson Howe authored
When initially created from modules page, new quizzes have type assignment, so type alone cannot be used when grouping items into sections. fixes LS-3039 flag = none Test plan: - Go to modules - Create an empty module - Create a classic quiz and a new quiz from the 'Add item' modal - (Don't refresh the page at all) - Click 'Edit' module - Click 'Add requirement' - Expect new and classic quizzes to be grouped together under 'Quizzes heading' Change-Id: I34a0b535cc07d913c85b50946a6e94e036812b2c Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287151 Tested-by:
-
Jacob Burroughs authored
And bump switchman to patch the pg adapter earlier in boot Change-Id: I88baa87b0894e7252229109f2e0b89af10754ca9 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287663 Reviewed-by:
-
James Butters authored
This reverts commit 18e78b3c. Reason for revert: didn't break jenkins Change-Id: I5074570df6eeaf249cc380210cb20d8fc2439b80 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286902 Tested-by:
Isaac Moore <isaac.moore@instructure.com> QA-Review: James Butters <jbutters@instructure.com> Product-Review: James Butters <jbutters@instructure.com>
-
Jacob Burroughs authored
Change-Id: Ide7490f4e8d2447b147328b6f7e2afc545941c14 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287599 Reviewed-by:
-
Drake Harper authored
flag=none fixes VICE-2587 Test Plan: - go to the people page for a course - type in the search field > should filter roster as you type > search input field should have a magnifying glass icon on the left side of the input, matching desings Change-Id: I2d6a3a929b9f8ab05241ab791e16c3bcab845d99 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287469 Reviewed-by:Jeffrey Johnson <jeffrey.johnson@instructure.com> Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com> QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com> QA-Review: Caleb Guanzon <cguanzon@instructure.com> Tested-by:
-
Aaron Ogata authored
This reverts commit e0841f7c. Reason for revert: broke Jenkins Change-Id: I6c6b74582096b9877fa71ee3733d11bf27217b2b Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286901 Tested-by:
Andrea Cirulli <andrea.cirulli@instructure.com> Reviewed-by:
Alex Slaughter <aslaughter@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com>
-
James Butters authored
[change-merged] [build-registry-path=jenkins/canvas-lms/de1103] flag = none Test Plan: -Jenkins passes normally, no new builds ran -With new/deleted spec file -Jenkins will not run the crystalball map build -Jenkins will run all rspec tests, no prediction -With new/deleted spec file and post-merge -Jenkins will trigger a new crystalball map build -main post-merge build will not wait for map build Change-Id: I77cddacfb98c8e77798eab276fc5cf08fb524cd3 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287658 Tested-by:
-
Kai Bjorkman authored
closes EVAL-1822 flag=none Test Plan: -specs pass Change-Id: Ia01492328635f7b6c635e0b00b362e70ba698a02 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/271231 Tested-by:Syed Hussain <shussain@instructure.com> QA-Review: Kai Bjorkman <kbjorkman@instructure.com> Product-Review: Syed Hussain <shussain@instructure.com>
-
Xander Moffatt authored
why: * it's hard to remember all the places in the Canvas UI that you can create deep links, or places that you would expect to see them * keep the placement config as the one source of truth while still providing helpful user-facing context refs INTEROP-6708 flag=none test plan: * confirm that the info I wrote is correct (which I did, I just tested all of these places) Change-Id: I3e2a505fa03b4e77611cd355823b46173f84c2b2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287478 Tested-by:
Evan Battaglia <ebattaglia@instructure.com> QA-Review: Xander Moffatt <xmoffatt@instructure.com> Product-Review: Xander Moffatt <xmoffatt@instructure.com>
-
Xander Moffatt authored
why: * currently only assignment-associated LTI resource links send their unique resource_link_id in the LTI launch, while other LTI resource links (like module items, RCE content etc) use the context resource link id * this is in violation of the LTI spec and has been for a long time closes INTEROP-6708 flag=none test plan: * create some LTI resource links in different places in a course * an LTI-type assignment * an LTI launch module item * an LTI resource link in an RCE instance * each of these should have an `Lti::ResourceLink` model associated with them, with a resource_link_uuid * launching each of these links should include that uuid in the resource_link_id claim of the LTI launch message Change-Id: I49e1de494dd16a9c12a3ab27900291014675e1a6 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287450 Tested-by:
-
Ed Schiebel authored
closes LS-3046 flag=none test plan: passes flakey spec catcher Change-Id: Ic9645eee7c9c6f3ac2b5d2369b4ebae61c5bfd12 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287613 Reviewed-by:
Jackson Howe <jackson.howe@instructure.com> Reviewed-by:
James Butters <jbutters@instructure.com> QA-Review: Jackson Howe <jackson.howe@instructure.com> Tested-by:
-
- 21 Mar, 2022 15 commits
-
-
Xander Moffatt authored
why: * it's hard to remember all the places in the Canvas UI that you can create deep links, or places that you would expect to see them * keep the placement config as the one source of truth while still providing helpful user-facing context refs INTEROP-6708 flag=none test plan: * confirm that the info I wrote is correct (which I did, I just tested all of these places) Change-Id: I3e2a505fa03b4e77611cd355823b46173f84c2b2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287478 Tested-by:
-
Xander Moffatt authored
why: * currently only assignment-associated LTI resource links send their unique resource_link_id in the LTI launch, while other LTI resource links (like module items, RCE content etc) use the context resource link id * this is in violation of the LTI spec and has been for a long time closes INTEROP-6708 flag=none test plan: * create some LTI resource links in different places in a course * an LTI-type assignment * an LTI launch module item * an LTI resource link in an RCE instance * each of these should have an `Lti::ResourceLink` model associated with them, with a resource_link_uuid * launching each of these links should include that uuid in the resource_link_id claim of the LTI launch message Change-Id: I49e1de494dd16a9c12a3ab27900291014675e1a6 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287450 Tested-by:
-
Ed Schiebel authored
closes LS-3046 flag=none test plan: passes flakey spec catcher Change-Id: Ic9645eee7c9c6f3ac2b5d2369b4ebae61c5bfd12 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287613 Reviewed-by:
-
Ed Schiebel authored
where it was previously shown in just weeks. refs LS-3008 flag=course_paces test plan: - in a course with some assignments in a pace plan - fiddle with the days inputs to change the length of the plan > expect the plan length to be correct time between start and the last assignment due date Change-Id: Ie9f915d26f08d730dceb74855a54c9c0287b4f54 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287163 Tested-by: -
Evan Battaglia authored
Needed to fix all_roles to properly dedup (it was joining some with "," before doing the 'uniq'). closes INTEROP-7282 flag=none Test plan: - Go to a course and make a student - use StudentView in the upper-right - Hit NRPS for the course, e.g., http web.canvas-lms2.docker/api/lti/courses/61/names_and_roles \ Authorization:\ Bearer\ myltiadvantagetoken - The test student should have "Learner" and "TestUser" roles - The regular student should just just have the "Learner" role - Launch an LTI 1.3 tool in this course as the test student and look at the roles claim. It should have (same as before this commit): "http://purl.imsglobal.org/vocab/lis/v2/institution/person#Student", "http://purl.imsglobal.org/vocab/lis/v2/system/person#User", "http://purl.imsglobal.org/vocab/lti/system/person#TestUser" "Learner" and "TestUser" role (and possibly others), with no - Launch an LTI 1.3 tool in an account context. It should have these roles (same as before this commit): "http://purl.imsglobal.org/vocab/lis/v2/institution/person#Student", "http://purl.imsglobal.org/vocab/lis/v2/membership#Learner", "http://purl.imsglobal.org/vocab/lis/v2/system/person#User", "http://purl.imsglobal.org/vocab/lti/system/person#TestUser" Change-Id: I968674b8445b8833de3e57d900b67286d7fd8a23 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287501 Reviewed-by: -
Weston Dransfield authored
Closes MAT-690 flag=none This will do the following: 1. Increae the max tree depth to 10_000 (which is the max the Quizzes team set elsewhere). This will allow most of the broken pages to be viewed again 2. Do not allow saving content over the max tree depth. An error will now be raised If we still find that some users have gone over the (quite large) treed depth limit, we can selectivly fix up those pages. I was not able to find any in my searching, however. Test Plan: 1. Follow the steps to reproduce the issue in this comment: https://instructure.atlassian.net/ browse/MAT-690?focusedCommentId=1392048 2. Verify you are now permitted to save the content 3. Modify this value from 10_000 to 1: https://livegrep.inscloudgate.net/view/ canvas-lms/gems/canvas_sanitize/lib/ canvas_sanitize/canvas_sanitize.rb#L74 4. Restart rails server 5. Attempt to save a page with a few nested elements 6. Validate you see an error describing the issues Change-Id: I58d0014d07f4969cf7028162b49f7e4df57caf68 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287465 Tested-by:
Juan Chavez <juan.chavez@instructure.com> QA-Review: Juan Chavez <juan.chavez@instructure.com> Product-Review: David Lyons <lyons@instructure.com>
-
Isaac Moore authored
This endpoint previously had an unhandled error when `grade_data` was missing. This fixes it so that it instead returns an error to the caller. fixes DE-1097 fixes CANVAS-HQBT flag=none test plan: - call endpoint with parameter missing - verify the user receives an error, and there is no unhandled Rails error - call endpoint without parameter missing - verify the error is not returned Change-Id: I97b837fd513000bc2265153f54b6d4882766e417 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287502 Product-Review: Isaac Moore <isaac.moore@instructure.com> Tested-by:
Jeremy Stanley <jeremy@instructure.com> QA-Review: Jeremy Stanley <jeremy@instructure.com>
-
Jonathan Guardado authored
The k5Dashboard js tests suit was splitted into 4 different files one for each of the sections that take more time to be executed, those are the basic functionality, planner, observer, and tabs, so they have their own file now. closes: LS-3014 flag= none Test plan: - Passes Jenkins Change-Id: I13b81cf6396e72a3064a1e82ca333cfa7c7d3ea2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287500 Tested-by:
-
Ed Schiebel authored
- remove the Show Projections button - show static text for dates - move "x Assignments | y weeks" to its new location refs LS-3008 flag=course_pacing test plan: - in a course in the default term with a pace plan (doesn't have to be the default term, but know that you can't have a specified term with missing start or end dates, so those tests have to be run for the course dates only) *** for the course plan *** - in settings, set participation to Term or Course but leave start and end dates empty > expect today as the start date > expect the last assignment's due date as the end date - give the course or term a start date > expect the course or term start to be the start date . expect the last assignment's due date as the end date - give the course a start and end date > expect the course or term start to be the start date > expet the term or course to be the end date - give the course a end date only > expect today as the start date > expect a Course or Term completion as the end date - switch to a student plan - redo the above > expect the start date to always be the student enrollment date > expect the end date to always be determined by course pacing Change-Id: I11cbd8c460dffdda94d161c62d8e97c468db442e Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287160 Tested-by: -
Evan Battaglia authored
This is currently repeating the course/account name, which is already the crumb before it. It should be the tool name. Account to WCAG guidelines, as it is the current page, it shouldn't be a link (no second arg to add_crumb()). - also, get rid of useless add_crumb where we are doing a borderless LTI launch - also dedup a couple specs - also fix spec to test what it says it's testing (domain matching in /retrieve endpoint) closes INTEROP-2687 flag=none Test plan: - have a tool with account_navigation. Go to the link to it in the account nav (URL is something like /accounts/2/external_tools/18). - the breadcrumbs should have two parts: the account name (a link to the account), and the tool name (not a link) course_navigation - repeat the above steps for a tool with course navigation. the breadcrumbs should be the course name (link to the course) and the tool name (not a course) - launch a tool using the `retrieve` endpoint. One way is to go to /accounts/self/external_tools/retrieve?url=<url of the tool>. Or, you can generate such a URL by using the LTI 1.3 test tool in the RCE, which will generate a link to the 'retrieve' in the course context. Again, as before, check that the breadcrumb is the course or account name (link to course or account) plus the tool name (not a link) Change-Id: Iec82bc00a4f10226fb0e9156e37b7d712232a910 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287372 Tested-by:
-
Jacob Burroughs authored
Change-Id: I6bcce0e81b6a79dc5e0a693d3fc4669437643d8a Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287546 Tested-by:
-
Ed Schiebel authored
The planner was recently changed to retrieve the course list via the dashboar_card api call rather than ENV and it was not getting rerendered once the list became available. Retrieving the course list from the redux store solves the issue. closes LS-3045 flag=none test plan: - have a student with course(s) with todo assignments or course calendar events - load their card dashboard > expect the course name to be included in the entry on the To Do List in the sidebar. Change-Id: I4b32676e72f095fbc8a19d5e094956352f966eae Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287538 Reviewed-by: -
Aaron Ogata authored
because patchset revision gets set to an actual value elsewhere Change-Id: I792b7bf96ddca1309e13b79782cce2ceb3471ebc Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287552 Reviewed-by:
Bobby Buten <bobby.buten@instructure.com> QA-Review: Aaron Ogata <aogata@instructure.com> Product-Review: Aaron Ogata <aogata@instructure.com> Tested-by:
-
Aaron Ogata authored
Change-Id: I0c3a24600d583f7472a5d9f4aa318db1e4a1ae0b Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287542 Reviewed-by:
-
paulo.chaves authored
Closes EVAL-2311 flag=none test plan: - As a teacher - Create an assignment with a due date - As a student - Add a submission past due date - Go to the grades page the late pill should be orange - Go to the assignments page the late pill should be orange Change-Id: I4589627f9fb3cebec3505a795733aada7182a01a Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286342 Tested-by:
-
- 19 Mar, 2022 2 commits
-
-
Jenkins authored
Change-Id: I5495d75a0c021aa757437d505215fc8a68dd941d Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287504 Tested-by:
-
Jenkins authored
Change-Id: I2e28b7349617a2cd93acdce1265a4e509fd2035f Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287503 Tested-by:
-
- 18 Mar, 2022 2 commits
-
-
jake.oeding authored
fixes MAT-743 flag=react_discussions_post flag=rce_mentions_in_discussions test plan: -enable the feature flags -have a course with multiplea people enrolled -navigate to discussions -start a discussion or comment in an existing one -trigger the mention dropdown by typing @ in the RCE -run the a11y checker >observe it does not complain about alt text on the avatar images Change-Id: Ieb5293d18d1721ef8d714f8ac46d6c835f8990f7 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287430 Reviewed-by:
Weston Dransfield <wdransfield@instructure.com> QA-Review: Weston Dransfield <wdransfield@instructure.com> Product-Review: David Lyons <lyons@instructure.com> Tested-by:
-
Jeremy Stanley authored
test plan: - do API calls to /api/v1/accounts/X/users?enrollment_type[]=Y where Y includes: - plain enrollment types like `student`, `teacher`, or `ta` (this is what is documented and what works today) - full enrollment types like `StudentEnrollment` or `TaEnrollment` (this doesn't work but Sentry logs show a lot of people try it anyway, so we'll make it work) - snake case enrollment types like `student_enrollment` - might as well make those work too - invalid enrollment types like `lolcats`. this should result in a 400 error with a meaningful error result, and not, as happens today, with a 500 error and an error_report flag=none fixes DE-1094 fixes CANVAS-HQJX Change-Id: I38b6a788d41ee68aad426e159d15df16ec1a0e4a Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287471 QA-Review: Isaac Moore <isaac.moore@instructure.com> Product-Review: Jeremy Stanley <jeremy@instructure.com> Tested-by:
-
