GitLab

Included a non-empty href attribute to the Link component
so we generated the appropriate <a> tag. had to re-work how
we populate this compononent because rendering links within
links is not desirable behavior when working with React
components.

refs FOO-2754
flag = none

Test plan:
1. Account --> Settings
2. Acceptable Use Policy --> uncheck
   "Allow passive acceptance of Terms of Service"
3. Have a user with: user.preferences[:accepted_terms] = nil
4. At the login screen verify "Acceptable Use Policy" link
   looks formatted in-line with the other links in the footer
5. Log in with that user and verify that the
   Acceptance Use Policy modal links are underlined by default
6. Accept the policy and verify the links rendered in the footer
   of the user's Dashboard are also formatted appropriately,
   specifically the "Acceptable Use Policy" link that is now
   underlined by default for better accessibility.

Change-Id: I428911ec1fcacbb66c39e45a4fe5242bb694d39d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287852

Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: August Thornton <august@instructure.com>